On Tue, 29 Jul 2025, Krzysztof Kozlowski wrote: > On 28/07/2025 08:58, Nam Tran wrote: > > ... > > > +MODULE_DEVICE_TABLE(of, of_lp5812_match); > > + > > +static struct i2c_driver lp5812_driver = { > > + .driver = { > > + .name = "lp5812", > > + .of_match_table = of_match_ptr(of_lp5812_match), > > v11 was okay here... now you introduced errors. Thank you for pointing that out. You're absolutely right. Since the LP5812 driver is DT-only and doesn't support non-DT probing, using of_match_ptr() is unnecessary and potentially incorrect. I'll drop of_match_ptr() and directly assign the of_match_table. Thanks again for the review! Best regards, Nam Tran