Am 26.07.25 um 22:40 schrieb Derek J. Clark:
Adds an EC controlled LED Multicolor Class Device for controlling the
RGB rings around the joysticks.
The EC provides a single register for each of the colors red, green, and
blue, as well as a mode switching register. The EC accepts values
[0-255] for all colors. There are two available effects: breathe, which is
the default when the device is started, and monocolor. When resuming from
sleep the user selected effect will be overwritten by the EC, so the
driver retains the last setting and resets on resume. When setting a
color, each color register is set before a final "write" code is sent to
the device. The EC may briefly reflect the "write" code when writing, but
quickly changes to the "monocolor" value once complete. The driver
interprets both of these values as "monocolor" in _show to simplify the
sysfs exposed to the user.
Two custom attributes are added to the standard LED parent device:
effect, a RW file descriptor used to set the effect, and effect_index,
which enumerates the available valid options.
Signed-off-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
---
drivers/platform/x86/Kconfig | 3 +
drivers/platform/x86/ayn-ec.c | 285 ++++++++++++++++++++++++++++++++++
2 files changed, 288 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4819bfcffb6b..85dfb88cca6f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -308,6 +308,9 @@ config AYN_EC
tristate "AYN x86 devices EC platform control"
depends on ACPI
depends on HWMON
+ depends on NEW_LEDS
+ select LEDS_CLASS
+ select LEDS_CLASS_MULTICOLOR
help
This is a driver for AYN and Tectoy x86 handheld devices. It provides
temperature monitoring, manual fan speed control, fan curve control,
diff --git a/drivers/platform/x86/ayn-ec.c b/drivers/platform/x86/ayn-ec.c
index 466cc33adcb0..25f748d7db18 100644
--- a/drivers/platform/x86/ayn-ec.c
+++ b/drivers/platform/x86/ayn-ec.c
@@ -28,6 +28,8 @@
#include <linux/hwmon.h>
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/led-class-multicolor.h>
+#include <linux/leds.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/sysfs.h>
@@ -68,6 +70,16 @@
#define AYN_SENSOR_PROC_TEMP_REG 0x09 /* CPU Core */
#define AYN_SENSOR_VCORE_TEMP_REG 0x08 /* vCore */
+/* EC Controlled RGB registers */
+#define AYN_LED_MC_RED_REG 0xB0 /* Range 0x00-0xFF */
+#define AYN_LED_MC_GREEN_REG 0xB1 /* Range 0x00-0xFF */
+#define AYN_LED_MC_BLUE_REG 0xB2 /* Range 0x00-0xFF */
+#define AYN_RGB_EFFECT_REG 0xB3
+
+/* RGB effect modes */
+#define AYN_RGB_EFFECT_BREATHE 0x00
+#define AYN_RGB_EFFECT_MONOCOLOR 0x55
+#define AYN_RGB_EFFECT_WRITE 0xAA
/* Handle ACPI lock mechanism */
#define ACPI_LOCK_DELAY_MS 500
@@ -86,7 +98,9 @@ int ayn_pwm_curve_registers[10] = {
};
struct ayn_device {
+ struct led_classdev *led_cdev;
u32 ayn_lock; /* ACPI EC Lock */
+ u8 rgb_effect;
} drvdata;
struct thermal_sensor {
@@ -103,6 +117,33 @@ static struct thermal_sensor thermal_sensors[] = {
{}
};
+#define DEVICE_ATTR_RW_NAMED(_name, _attrname) \
+ struct device_attribute dev_attr_##_name = { \
+ .attr = { .name = _attrname, .mode = 0644 }, \
+ .show = _name##_show, \
+ .store = _name##_store, \
+ }
+
+#define DEVICE_ATTR_RO_NAMED(_name, _attrname) \
+ struct device_attribute dev_attr_##_name = { \
+ .attr = { .name = _attrname, .mode = 0444 }, \
+ .show = _name##_show, \
+ }
Please use DEVICE_ATTR_RW()/DEVICE_ATTR_RO() directly.
+
+/* Handle ACPI lock mechanism */
+#define ACPI_LOCK_DELAY_MS 500
You already defined ACPI_LOCK_DELAY_MS earlier, please remove.
+
+/* RGB effect values */
+enum RGB_EFFECT_OPTION {
+ BREATHE,
+ MONOCOLOR,
+};
+
+static const char *const RGB_EFFECT_TEXT[] = {
+ [BREATHE] = "breathe",
+ [MONOCOLOR] = "monocolor",
+};
No capslock for variables please.
+
static bool lock_global_acpi_lock(void)
{
return ACPI_SUCCESS(acpi_acquire_global_lock(ACPI_LOCK_DELAY_MS,
@@ -528,10 +569,253 @@ static struct attribute *ayn_sensors_attrs[] = {
ATTRIBUTE_GROUPS(ayn_sensors);
+/**
+ * rgb_effect_write() - Set the RGB effect stored in drvdata.rgb_effect.
+ */
+static int rgb_effect_write(void)
+{
+ return write_to_ec(AYN_RGB_EFFECT_REG, drvdata.rgb_effect);
+};
+
+/**
+ * rgb_effect_read() - Read the RGB effect and store it in drvdata.rgb_effect.
+ */
+static int rgb_effect_read(void)
+{
+ int ret;
+ long effect;
+
+ ret = read_from_ec(AYN_RGB_EFFECT_REG, 1, &effect);
+ if (ret)
+ return ret;
+
+ switch (effect) {
+ case AYN_RGB_EFFECT_WRITE:
+ case AYN_RGB_EFFECT_MONOCOLOR:
+ drvdata.rgb_effect = AYN_RGB_EFFECT_WRITE;
+ break;
+ default:
+ drvdata.rgb_effect = AYN_RGB_EFFECT_BREATHE;
You will need some locking around rgb_effect.
+ }
+
+ return 0;
+}
+
+/**
+ * rgb_effect_store() - Store the given RGB effect and set it.
+ *
+ * @dev: parent device of the given attribute.
+ * @attr: The attribute to write to.
+ * @buf: Input value string from sysfs write.
+ * @count: The number of bytes written.
+ *
+ * Return: The number of bytes written, or an error.
+ */
+static ssize_t rgb_effect_store(struct device *dev,
+ struct device_attribute *attr, const char *buf,
+ size_t count)
+{
+ int ret;
+
+ ret = sysfs_match_string(RGB_EFFECT_TEXT, buf);
+ if (ret < 0)
+ return ret;
+
+ if (ret)
+ drvdata.rgb_effect = AYN_RGB_EFFECT_WRITE;
+ else
+ drvdata.rgb_effect = AYN_RGB_EFFECT_BREATHE;
+
+ ret = rgb_effect_write();
+ if (ret)
+ return ret;
+
+ return count;
+};
+
+/**
+ * rgb_effect_show() - Read the current RGB effect.
+ *
+ * @dev: parent device of the given attribute.
+ * @attr: The attribute to read.
+ * @buf: Buffer to read to.
+ *
+ * Return: The number of bytes read, or an error.
+ */
+static ssize_t rgb_effect_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ int ret, i;
+
+ ret = rgb_effect_read();
+ if (ret)
+ return ret;
+
+ switch (drvdata.rgb_effect) {
+ case AYN_RGB_EFFECT_WRITE:
+ case AYN_RGB_EFFECT_MONOCOLOR:
+ i = MONOCOLOR;
+ break;
+ default:
+ i = BREATHE;
+ break;
+ }
+
+ return sysfs_emit(buf, "%s\n", RGB_EFFECT_TEXT[i]);
+};
+
+static DEVICE_ATTR_RW_NAMED(rgb_effect, "effect");
+
+/**
+ * rgb_effect_show() - Display the RGB effects available.
+ *
+ * @dev: parent device of the given attribute.
+ * @attr: The attribute to read.
+ * @buf: Buffer to read to.
+ *
+ * Return: The number of bytes read, or an error.
+ */
+static ssize_t rgb_effect_index_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ size_t count = 0;
+ unsigned int i;
+
+ for (i = 0; i < ARRAY_SIZE(RGB_EFFECT_TEXT); i++)
+ count += sysfs_emit_at(buf, count, "%s ", RGB_EFFECT_TEXT[i]);
+
+ buf[count - 1] = '\n';
+
+ return count;
+}
+
+static DEVICE_ATTR_RO_NAMED(rgb_effect_index, "effect_index");
We might need to coordinate this with the LED subsystem maintainer. I CCed him so that he can
voice his opinion about those sysfs attributes. Personally i would move those attributes below
the platform device.
