Štěpán Němec <stepnem@xxxxxxxx> writes:
> On Mon, 28 Jul 2025 13:07:58 -0600
> Jonathan Corbet wrote:
>
>> Štěpán Němec <stepnem@xxxxxxxx> writes:
>>
>>> Fixes: 46c4c9d1beb7 ("pipe: increase minimum default pipe size to 2 pages")
>>> Signed-off-by: Štěpán Němec <stepnem@xxxxxxxx>
>>> ---
>
> [...]
>
>> This seems like a reasonable change, but can I ask you to resubmit it
>> with a proper changelog, please?
>
> Do you mean a better/longer commit message?
>
> I felt that the Subject: and Fixes: says it all and didn't
> want to duplicate information (contained in its commit
> message and comments added by that change, as well as the
> very paragraph we're updating here).
>
> Would adding something like
>
> The pipe size limit used when the fs.pipe-user-pages-soft
> sysctl value is reached was increased from one to two
> pages in commit 46c4c9d1beb7; update the documentation to
> match the new reality.
>
> work?
Yes, that is what I had in mind. Patches should always explain
themselves without making people chase down Fixes tags and such.
Thanks,
jon
