> > +
> > + platform_set_drvdata(pdev, pmu);
> > + pmu->dev = &pdev->dev;
> > +
> > + pmu->cfg = device_get_match_data(pmu->dev);
> > +
> > + pmu->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> > + if (IS_ERR(pmu->membase))
> > + return PTR_ERR(pmu->membase);
> > +
> > + if (of_property_present(pmu->dev->of_node, "access-controllers")) {
> > + ret = stm32_firewall_get_firewall(pmu->dev->of_node, &firewall, 1);
>
> Jiri is busy driving dev_fwnode() thorugh to get rid of all the directly references
> to of_node. Probably better to use that here from the start.
>
Need more coffee. Ignore this one, you still need an of_node here.
>
> > + if (ret)
> > + return dev_err_probe(pmu->dev, ret, "Failed to get firewall\n");
> > + ret = stm32_firewall_grant_access_by_id(&firewall, firewall.firewall_id);
> > + if (ret)
> > + return dev_err_probe(pmu->dev, ret, "Failed to grant access\n");
> > + }
> > +
