Re: [PATCH] docs: filesystems: sysfs: Recommend sysfs_emit() for new code only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart!

> -- show() should only use sysfs_emit() or sysfs_emit_at() when
> formatting

With my standards hat on: That's a "should", not a "shall". But I guess
the "only" makes it sound slightly less optional.

> +- New implementations of show() methods should only use sysfs_emit() or
> +  sysfs_emit_at() when formatting the value to be returned to user
>    space.

Should we make this a "shall" for new implementations?

I'm fine either way.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux