Re: [PATCH v15 24/34] fs/resctrl: Report 'Unassigned' for MBM events in mbm_event mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Reinette,

On 7/22/2025 9:05 PM, Reinette Chatre wrote:
Hi Babu,

On 7/22/25 5:26 PM, Moger, Babu wrote:

There is no redundant text now. . Users can look up about "mbm_event" from "mbm_assign_mode". Here is the complete diff.

diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index 446736dbd97f..01c33f62ce74 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -434,6 +434,12 @@ When monitoring is enabled all MON groups will also contain:
         for the L3 cache they occupy). These are named "mon_sub_L3_YY"
         where "YY" is the node number.

+       When the 'mbm_event' counter assignment mode is enabled, reading
+       an MBM event of a MON group returns 'Unassigned' if no hardware
+       counter is assigned to it. For CTRL_MON groups, 'Unassigned' is
+       returned if none of the events in the CTRL_MON group or its
+       associated MON groups have assigned counters.

The "none of the events" could be interpreted wrongly with only one MBM event
being read. How about the last sentence as:
	For CTRL_MON groups, 'Unassigned' is returned if the MBM event does not
	have an assigned counter in the CTRL_MON group nor in any of its associated
	MON groups.


Yes. Looks good.
Thanks
Babu




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux