On Tue, Jul 22, 2025 at 03:18:41PM +0800, Fan Gong wrote: ... > +void hinic3_free_db_addr(struct hinic3_hwdev *hwdev, const u8 __iomem *db_base) > +{ > + struct hinic3_hwif *hwif; > + uintptr_t distance; > + u32 idx; > + > + hwif = hwdev->hwif; > + distance = (const char __iomem *)db_base - > + (const char __iomem *)hwif->db_base; nit: These casts seem unnecessary. > + idx = distance / HINIC3_DB_PAGE_SIZE; > + > + free_db_idx(hwif, idx); > +} ...