Re: [PATCH v2 02/15] net: rnpgbe: Add n500/n210 chip support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Yes, I got it before, and I really tried to improve my code.
> But this is really hard to avoid here.

Agreed. When writing the driver, you need to write it in such a way it
can be reviewed. And that is a skill in its own.

Sometimes, you end up writing the driver twice. First time you just
concentrate on getting it working. The second time you write the
driver, you break it up into smaller, self contained chunks, which are
easy to review.

	Andrew




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux