On Mon, Jul 21, 2025 at 02:30:40PM +0100, Vadim Fedorenko wrote: > > +/* Device IDs */ > > +#ifndef PCI_VENDOR_ID_MUCSE > > +#define PCI_VENDOR_ID_MUCSE 0x8848 > > +#endif /* PCI_VENDOR_ID_MUCSE */ Hi Vadim Please trim the quoted text when doing reviews. > > this should go to include/linux/pci_ids.h without any ifdefs Actually, no. include/linux/pci_ids.h says: /* SPDX-License-Identifier: GPL-2.0 */ /* * PCI Class, Vendor and Device IDs * * Please keep sorted by numeric Vendor ID and Device ID. * * Do not add new entries to this file unless the definitions * are shared between multiple drivers. */ But the #ifndef should be removed. Andrew
