Re: [PATCH v3] docs: document linked lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nikolay Borisov <nik.borisov@xxxxxxxx> writes:

> Nit: I think it's unnecessary to repeat the initilization in code since 
> you've already explicitly mentioned you continue form State 2 of the 
> previous example, so the only salient information is the additional 
> list_bulk_move_tail call.

[...]

I have a nit of my own: now that the kerneldoc for the hlist functions
is here (it naturally moved with the rest), it would be nice to have
some sort of mention, even if just a paragraph saying why hlists exist
and when one might want to use them.

That said, I have gone ahead and applied this; we've put Nicolas through
enough rounds, and I'd like to get this in for the 6.17 merge window.
The nits can be addressed at leisure with follow-on patches.

Thanks,

jon




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux