Hi,
This series by Shahar implements graceful period delay in devlink health
reporter, and use it in mlx5e driver.
See detailed feature description by Shahar below [1].
Regards,
Tariq
[1]
Currently, the devlink health reporter initiates the grace period
immediately after recovering an error, which blocks further recovery
attempts until the grace period concludes. Since additional errors
are not generally expected during this short interval, any new error
reported during the grace period is not only rejected but also causes
the reporter to enter an error state that requires manual intervention.
This approach poses a problem in scenarios where a single root cause
triggers multiple related errors in quick succession - for example,
a PCI issue affecting multiple hardware queues. Because these errors
are closely related and occur rapidly, it is more effective to handle
them together rather than handling only the first one reported and
blocking any subsequent recovery attempts. Furthermore, setting the
reporter to an error state in this context can be misleading, as these
multiple errors are manifestations of a single underlying issue, making
it unlike the general case where additional errors are not expected
during the grace period.
To resolve this, introduce a configurable grace period delay attribute
to the devlink health reporter. This delay starts when the first error
is recovered and lasts for a user-defined duration. Once this grace
period delay expires, the actual grace period begins. After the grace
period ends, a new reported error will start the same flow again.
Timeline summary:
----|--------|------------------------------/----------------------/--
error is error is grace period delay grace period
reported recovered (recoveries allowed) (recoveries blocked)
With grace period delay, create a time window during which recovery
attempts are permitted, allowing all reported errors to be handled
sequentially before the grace period starts. Once the grace period
begins, it prevents any further error recoveries until it ends.
When grace period delay is set to 0, current behavior is preserved.
Shahar Shitrit (5):
devlink: Move graceful period parameter to reporter ops
devlink: Move health reporter recovery abort logic to a separate
function
devlink: Introduce grace period delay for health reporter
devlink: Make health reporter grace period delay configurable
net/mlx5e: Set default grace period delay for TX and RX reporters
Documentation/netlink/specs/devlink.yaml | 7 ++
.../networking/devlink/devlink-health.rst | 2 +-
drivers/net/ethernet/amd/pds_core/main.c | 2 +-
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +-
.../net/ethernet/huawei/hinic/hinic_devlink.c | 10 +-
.../net/ethernet/intel/ice/devlink/health.c | 3 +-
.../marvell/octeontx2/af/rvu_devlink.c | 32 +++--
.../mellanox/mlx5/core/diag/reporter_vnic.c | 2 +-
.../mellanox/mlx5/core/en/reporter_rx.c | 13 ++-
.../mellanox/mlx5/core/en/reporter_tx.c | 13 ++-
.../net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
.../net/ethernet/mellanox/mlx5/core/health.c | 41 ++++---
drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +-
drivers/net/ethernet/qlogic/qed/qed_devlink.c | 10 +-
drivers/net/netdevsim/health.c | 4 +-
include/net/devlink.h | 15 ++-
include/uapi/linux/devlink.h | 2 +
net/devlink/health.c | 109 +++++++++++++-----
net/devlink/netlink_gen.c | 5 +-
19 files changed, 191 insertions(+), 85 deletions(-)
base-commit: a96cee9b369ee47b5309311d0d71cb6663b123fc
--
2.31.1
