Hi Armin, kernel test robot noticed the following build errors: [auto build test ERROR on lwn/docs-next] [also build test ERROR on linus/master v6.16-rc5 next-20250711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Armin-Wolf/platform-x86-Add-Uniwill-WMI-driver/20250712-192556 base: git://git.lwn.net/linux.git docs-next patch link: https://lore.kernel.org/r/20250712112310.19964-3-W_Armin%40gmx.de patch subject: [PATCH 2/3] platform/x86: Add Uniwill laptop driver config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250713/202507131049.84GJKlqK-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250713/202507131049.84GJKlqK-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202507131049.84GJKlqK-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/platform/x86/uniwill/uniwill-laptop.c: In function 'uniwill_get_property': >> drivers/platform/x86/uniwill/uniwill-laptop.c:1060:23: error: implicit declaration of function 'power_supply_get_property_direct'; did you mean 'power_supply_get_property'? [-Werror=implicit-function-declaration] 1060 | ret = power_supply_get_property_direct(psy, POWER_SUPPLY_PROP_PRESENT, &prop); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | power_supply_get_property cc1: some warnings being treated as errors vim +1060 drivers/platform/x86/uniwill/uniwill-laptop.c 1048 1049 static int uniwill_get_property(struct power_supply *psy, const struct power_supply_ext *ext, 1050 void *drvdata, enum power_supply_property psp, 1051 union power_supply_propval *val) 1052 { 1053 struct uniwill_data *data = drvdata; 1054 union power_supply_propval prop; 1055 unsigned int regval; 1056 int ret; 1057 1058 switch (psp) { 1059 case POWER_SUPPLY_PROP_HEALTH: > 1060 ret = power_supply_get_property_direct(psy, POWER_SUPPLY_PROP_PRESENT, &prop); 1061 if (ret < 0) 1062 return ret; 1063 1064 if (!prop.intval) { 1065 val->intval = POWER_SUPPLY_HEALTH_NO_BATTERY; 1066 return 0; 1067 } 1068 1069 ret = power_supply_get_property_direct(psy, POWER_SUPPLY_PROP_STATUS, &prop); 1070 if (ret < 0) 1071 return ret; 1072 1073 if (prop.intval == POWER_SUPPLY_STATUS_UNKNOWN) { 1074 val->intval = POWER_SUPPLY_HEALTH_UNKNOWN; 1075 return 0; 1076 } 1077 1078 ret = regmap_read(data->regmap, EC_ADDR_BAT_ALERT, ®val); 1079 if (ret < 0) 1080 return ret; 1081 1082 if (regval) { 1083 /* Charging issue */ 1084 val->intval = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE; 1085 return 0; 1086 } 1087 1088 val->intval = POWER_SUPPLY_HEALTH_GOOD; 1089 return 0; 1090 case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD: 1091 ret = regmap_read(data->regmap, EC_ADDR_CHARGE_CTRL, ®val); 1092 if (ret < 0) 1093 return ret; 1094 1095 val->intval = clamp_val(FIELD_GET(CHARGE_CTRL_MASK, regval), 0, 100); 1096 return 0; 1097 default: 1098 return -EINVAL; 1099 } 1100 } 1101 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki