Akira Yokosawa <akiyks@xxxxxxxxx> writes: > On Thu, 10 Jul 2025 17:31:30 -0600, Jonathan Corbet wrote: > [...] > >> Changes since v1: >> - Coding-style tweaks requested by Mauro >> - Drop the reworking of output-text accumulation for now >> - Add a warning for prehistoric Python versions > > Serious review of python code is beyond my background, but I did a test > on this against opensuse/leap:15.6's python3-Sphinx_4_2_0, which comes with > python 3.6.15. > > Running "./scripts/kernel-doc.py -none include/linux/rcupdate.h" emits this: > > ------------------------------------------------------------------------ > Traceback (most recent call last): > File "./scripts/kernel-doc.py", line 315, in <module> > main() > File "./scripts/kernel-doc.py", line 286, in main > kfiles.parse(args.files, export_file=args.export_file) > File "/linux/scripts/lib/kdoc/kdoc_files.py", line 222, in parse > self.parse_file(fname) > File "/linux/scripts/lib/kdoc/kdoc_files.py", line 119, in parse_file > doc = KernelDoc(self.config, fname) > File "/linux/scripts/lib/kdoc/kdoc_parser.py", line 247, in __init__ > self.emit_message(0, > AttributeError: 'KernelDoc' object has no attribute 'emit_message' > ------------------------------------------------------------------------ > > This error appeared in 12/12. No errors with python3 >=3.9. Well, it does make it clear that things won't work properly with older Python... :) Seriously, though, that's embarrassing; I was clearly in too much of a hurry when I tossed that last patch in. Will fix. > I'm not sure but asking compatibility with python <3.9 increases > maintainers/testers' burden. Obsoleting <3.9 all together would > make everyone's life easier, wouldn't it? That is pretty much what we have done, this was just intended to let people know that they won't get the results they expect. Thanks, jon
