On Tue, Jul 08, 2025 at 07:40:35PM -0700, Sohil Mehta wrote:
> > @@ -664,14 +673,23 @@ static enum kernel_gp_hint get_kernel_gp_address(struct pt_regs *regs,
> > return GP_NO_HINT;
> >
> > #ifdef CONFIG_X86_64
>
> Might as well get rid of the #ifdef in C code, if possible.
>
> if (!IS_ENABLED(CONFIG_X86_64)
> return GP_CANONICAL;
>
> or combine it with the next check.
I tried this before. It triggers compiler error on 32-bit:
arch/x86/kernel/traps.c:673:16: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
673 | if (*addr >= ~__VIRTUAL_MASK)
| ^~~~~~~~~~~~~~
__VIRTUAL_MASK is not usable on 32-bit configs.
--
Kiryl Shutsemau / Kirill A. Shutemov
