Hi Babu,
On 7/1/25 9:23 AM, Moger, Babu wrote:
> Hi Reinette,
>
> On 6/25/25 18:24, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 6/13/25 2:05 PM, Babu Moger wrote:
>>> +static ssize_t resctrl_mbm_assign_on_mkdir_write(struct kernfs_open_file *of,
>>> + char *buf, size_t nbytes, loff_t off)
>>> +{
>>> + struct rdt_resource *r = rdt_kn_parent_priv(of->kn);
>>> + bool value;
>>> + int ret;
>>> +
>>> + ret = kstrtobool(buf, &value);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + mutex_lock(&rdtgroup_mutex);
>>> + rdt_last_cmd_clear();
>>> +
>>> + r->mon.mbm_assign_on_mkdir = value;
>>> +
>>> + mutex_unlock(&rdtgroup_mutex);
>>> +
>>> + return ret ?: nbytes;
>>
>> The static checker I tried complained here that ret can only be zero here.
>>
>
> It should be
>
> return 0;
>
hmmm ... I think it should be "return nbytes"
Reinette
