On Sat, 28 Jun 2025 12:04:04 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > On 6/27/25 3:10 AM, Petr Tesarik wrote: > > Document the dma_pool_zalloc() wrapper. > > > > Signed-off-by: Petr Tesarik <ptesarik@xxxxxxxx> > > --- > > Documentation/core-api/mm-api.rst | 2 ++ > > include/linux/dmapool.h | 8 ++++++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/Documentation/core-api/mm-api.rst b/Documentation/core-api/mm-api.rst > > index af8151db88b28..a61766328ac06 100644 > > --- a/Documentation/core-api/mm-api.rst > > +++ b/Documentation/core-api/mm-api.rst > > @@ -97,6 +97,8 @@ DMA pools > > .. kernel-doc:: mm/dmapool.c > > :export: > > > > +.. kernel-doc:: include/linux/dmapool.h > > + > > More Memory Management Functions > > ================================ > > > > diff --git a/include/linux/dmapool.h b/include/linux/dmapool.h > > index 06c4de602b2f3..c0c7717d3ae7b 100644 > > --- a/include/linux/dmapool.h > > +++ b/include/linux/dmapool.h > > @@ -60,6 +60,14 @@ static inline struct dma_pool *dma_pool_create(const char *name, > > NUMA_NO_NODE); > > } > > > > +/** > > + * dma_pool_zalloc - Get a zero-initialized block of DMA coherent memory. > > + * @pool: dma pool that will produce the block > > + * @mem_flags: GFP_* bitmask > > + * @handle: pointer to dma address of block > > + * > > + * Same as @dma_pool_alloc, but the returned memory is zeroed. > > * Same as dma_pool_alloc(), but ... > > '@' is for function arguments. Oops. Somehow sneaked in... > With that change: > > Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Do I have to submit a v3 then? Petr T
