Hi Pankaj, thank you for the patchset and sorry for jumping late. On 25-06-19, Pankaj Gupta wrote: ... > --- > Pankaj Gupta (7): > Documentation/firmware: add imx/se to other_interfaces > dt-bindings: arm: fsl: add imx-se-fw binding doc > firmware: imx: add driver for NXP EdgeLock Enclave > firmware: imx: device context dedicated to priv > firmware: drivers: imx: adds miscdev I didn't had the time for a detailed review but the patches3-5 (e.g. all firmware: *) can be squashed. In patch3 you add a set of files which you're going to patch in patch4 and patch5. Please have a look at my comment on patch3. Regards, Marco > arm64: dts: imx8ulp: add secure enclave node > arm64: dts: imx8ulp-evk: add reserved memory property > > Documentation/ABI/testing/se-cdev | 43 + > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 ++ > .../driver-api/firmware/other_interfaces.rst | 123 +++ > arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 12 +- > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +- > drivers/firmware/imx/Kconfig | 13 + > drivers/firmware/imx/Makefile | 2 + > drivers/firmware/imx/ele_base_msg.c | 269 +++++ > drivers/firmware/imx/ele_base_msg.h | 95 ++ > drivers/firmware/imx/ele_common.c | 354 ++++++ > drivers/firmware/imx/ele_common.h | 49 + > drivers/firmware/imx/se_ctrl.c | 1145 ++++++++++++++++++++ > drivers/firmware/imx/se_ctrl.h | 128 +++ > include/linux/firmware/imx/se_api.h | 14 + > include/uapi/linux/se_ioctl.h | 97 ++ > 15 files changed, 2443 insertions(+), 3 deletions(-) > --- > base-commit: 9e9eef5925a5d2b1938484c4edc906e384145959 > change-id: 20240507-imx-se-if-a40055093dc6 > > Best regards, > -- > Pankaj Gupta <pankaj.gupta@xxxxxxx> > > >
