Hi Babu,
On 6/13/25 2:04 PM, Babu Moger wrote:
...
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index bbe57eff962b..22766b8b670b 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -255,38 +255,46 @@ enum resctrl_schema_fmt {
> RESCTRL_SCHEMA_RANGE,
> };
>
> +/**
> + * struct resctrl_mon - Monitoring related data of a resctrl resource.
> + * @num_rmid: Number of RMIDs available.
> + * @mbm_cfg_mask: Memory transactions that can be tracked when bandwidth
> + * monitoring events are configured.
"are configured" -> "can be configured" (like it was before). This is a property
that is discovered from hardware. The feature need not be in use for the property
to be valid.
Also, this version switches "Bandwidth sources" -> "Memory transactions". I think this
is a good change but it may be unexpected. Perhaps a snippet in changelog to
point out the motivation for this change: "Also switch "bandwidth sources" term
to "memory transactions" to use consistent term within resctrl for related monitoring
features". Please feel free to improve.
Reinette
