Re: [PATCH v10 4/7] iio: accel: adxl345: add inactivity feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 23, 2025 at 11:06:44PM +0200, Lothar Rubusch wrote:
> On Mon, Jun 23, 2025 at 11:44 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:

...

> > > +     case ADXL345_INACTIVITY:
> > > +             en = FIELD_GET(ADXL345_INACT_X_EN, axis_ctrl) |
> > > +                     FIELD_GET(ADXL345_INACT_Y_EN, axis_ctrl) |
> > > +                     FIELD_GET(ADXL345_INACT_Z_EN, axis_ctrl);
> >
> > As I pointed out earlier. the indentation is supposed to be on the same colomn
> > for 'F' letters.
> >
> 
> Let me allow a stupid question, when you mean on the same column, the
> above is wrong? Can you give me an example here how to fix it?

Your mail client mangles the original text (TABs) and it's most likely
impossible to see on your side what I meant (I already answered once with
the example).

Here is the example, use https://lore.kernel.org/linux-iio to see it via Web

		en = FIELD_GET(ADXL345_INACT_X_EN, axis_ctrl) |
		     FIELD_GET(ADXL345_INACT_Y_EN, axis_ctrl) |
		     FIELD_GET(ADXL345_INACT_Z_EN, axis_ctrl);

All 'F' letters occupy the same (by number) column in the sequential lines.

P.S.
Also you seems ignored my ask to remove the context you are not replying to.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux