On Sun, 15 Jun 2025 22:22:51 +0000
Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote:
> Setup regmap cache to cache register configuration, reducing bus traffic
> for repeated accesses to non volatile registers.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx>
Applied but there was some fuzz. That makes me wonder what
is different between our trees.
Maybe it will become clear later in the patch set.
Thanks
Jonathan
> ---
> drivers/iio/accel/adxl313.h | 3 +++
> drivers/iio/accel/adxl313_core.c | 18 ++++++++++++++++++
> drivers/iio/accel/adxl313_i2c.c | 6 ++++++
> drivers/iio/accel/adxl313_spi.c | 6 ++++++
> 4 files changed, 33 insertions(+)
>
> diff --git a/drivers/iio/accel/adxl313.h b/drivers/iio/accel/adxl313.h
> index 72f624af4686..2bc86ac8ffd4 100644
> --- a/drivers/iio/accel/adxl313.h
> +++ b/drivers/iio/accel/adxl313.h
> @@ -22,6 +22,7 @@
> #define ADXL313_REG_BW_RATE 0x2C
> #define ADXL313_REG_POWER_CTL 0x2D
> #define ADXL313_REG_INT_MAP 0x2F
> +#define ADXL313_REG_INT_SOURCE 0x30
> #define ADXL313_REG_DATA_FORMAT 0x31
> #define ADXL313_REG_DATA_AXIS(index) (0x32 + ((index) * 2))
> #define ADXL313_REG_FIFO_CTL 0x38
> @@ -54,6 +55,8 @@ extern const struct regmap_access_table adxl312_writable_regs_table;
> extern const struct regmap_access_table adxl313_writable_regs_table;
> extern const struct regmap_access_table adxl314_writable_regs_table;
>
> +bool adxl313_is_volatile_reg(struct device *dev, unsigned int reg);
> +
> enum adxl313_device_type {
> ADXL312,
> ADXL313,
> diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c
> index 2f26da5857d4..39f16f97bb4a 100644
> --- a/drivers/iio/accel/adxl313_core.c
> +++ b/drivers/iio/accel/adxl313_core.c
> @@ -46,6 +46,24 @@ const struct regmap_access_table adxl314_readable_regs_table = {
> };
> EXPORT_SYMBOL_NS_GPL(adxl314_readable_regs_table, IIO_ADXL313);
>
> +bool adxl313_is_volatile_reg(struct device *dev, unsigned int reg)
> +{
> + switch (reg) {
> + case ADXL313_REG_DATA_AXIS(0):
> + case ADXL313_REG_DATA_AXIS(1):
> + case ADXL313_REG_DATA_AXIS(2):
> + case ADXL313_REG_DATA_AXIS(3):
> + case ADXL313_REG_DATA_AXIS(4):
> + case ADXL313_REG_DATA_AXIS(5):
> + case ADXL313_REG_FIFO_STATUS:
> + case ADXL313_REG_INT_SOURCE:
> + return true;
> + default:
> + return false;
> + }
> +}
> +EXPORT_SYMBOL_NS_GPL(adxl313_is_volatile_reg, "IIO_ADXL313");
> +
> static int adxl312_check_id(struct device *dev,
> struct adxl313_data *data)
> {
> diff --git a/drivers/iio/accel/adxl313_i2c.c b/drivers/iio/accel/adxl313_i2c.c
> index a4cf0cf2c5aa..e8636e8ab14f 100644
> --- a/drivers/iio/accel/adxl313_i2c.c
> +++ b/drivers/iio/accel/adxl313_i2c.c
> @@ -21,6 +21,8 @@ static const struct regmap_config adxl31x_i2c_regmap_config[] = {
> .rd_table = &adxl312_readable_regs_table,
> .wr_table = &adxl312_writable_regs_table,
> .max_register = 0x39,
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> [ADXL313] = {
> .reg_bits = 8,
> @@ -28,6 +30,8 @@ static const struct regmap_config adxl31x_i2c_regmap_config[] = {
> .rd_table = &adxl313_readable_regs_table,
> .wr_table = &adxl313_writable_regs_table,
> .max_register = 0x39,
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> [ADXL314] = {
> .reg_bits = 8,
> @@ -35,6 +39,8 @@ static const struct regmap_config adxl31x_i2c_regmap_config[] = {
> .rd_table = &adxl314_readable_regs_table,
> .wr_table = &adxl314_writable_regs_table,
> .max_register = 0x39,
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> };
>
> diff --git a/drivers/iio/accel/adxl313_spi.c b/drivers/iio/accel/adxl313_spi.c
> index 9a16b40bff34..68e323e81aeb 100644
> --- a/drivers/iio/accel/adxl313_spi.c
> +++ b/drivers/iio/accel/adxl313_spi.c
> @@ -24,6 +24,8 @@ static const struct regmap_config adxl31x_spi_regmap_config[] = {
> .max_register = 0x39,
> /* Setting bits 7 and 6 enables multiple-byte read */
> .read_flag_mask = BIT(7) | BIT(6),
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> [ADXL313] = {
> .reg_bits = 8,
> @@ -33,6 +35,8 @@ static const struct regmap_config adxl31x_spi_regmap_config[] = {
> .max_register = 0x39,
> /* Setting bits 7 and 6 enables multiple-byte read */
> .read_flag_mask = BIT(7) | BIT(6),
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> [ADXL314] = {
> .reg_bits = 8,
> @@ -42,6 +46,8 @@ static const struct regmap_config adxl31x_spi_regmap_config[] = {
> .max_register = 0x39,
> /* Setting bits 7 and 6 enables multiple-byte read */
> .read_flag_mask = BIT(7) | BIT(6),
> + .volatile_reg = adxl313_is_volatile_reg,
> + .cache_type = REGCACHE_MAPLE,
> },
> };
>
