On 6/18/25 10:56 AM, Jonathan Cameron wrote:
> On Mon, 16 Jun 2025 22:13:53 +0200
>> +static int zl3073x_spi_probe(struct spi_device *spi)
>> +{
>> + struct device *dev = &spi->dev;
>> + struct zl3073x_dev *zldev;
>> +
>> + zldev = zl3073x_devm_alloc(dev);
>> + if (IS_ERR(zldev))
>> + return PTR_ERR(zldev);
>> +
>> + zldev->regmap = devm_regmap_init_spi(spi, &zl3073x_regmap_config);
>> + if (IS_ERR(zldev->regmap)) {
>> + dev_err_probe(dev, PTR_ERR(zldev->regmap),
>> + "Failed to initialize regmap\n");
>> + return PTR_ERR(zldev->regmap);
>
> return dev_err_probe();
> One of it's biggest advantages is that dev_err_probe() returns the
> ret value passed in avoiding duplication like this and saving
> a few lines of code each time.
@Ivan: since patch 13 requires IMHO a fix, please also take care of the
above in the next revision, thanks!
Paolo
