Hi Babu, On 6/11/25 2:23 PM, Babu Moger wrote: > The functions parse_cbm() and parse_bw() require mode and CLOSID to > validate the Capacity Bit Mask (CBM). It is passed through struct > rdtgroup in rdt_parse_data. Instead of passing them through struct > rdtgroup, pass mode and closid directly. Above looks like a combination of context and solution description. Expectation is for context, problem, and solution to be in this order and in separate paragraphs. > > This change enables parse_cbm() to be used for verifying CBM in io_alloc > feature. Is this the problem? It is not clear from changelog what problem is being solved. Also, please drop "This change" that is semantically the same as "This patch". Reinette
