Am 15.06.25 um 21:00 schrieb Randy Dunlap:
Hi,
On 6/15/25 10:59 AM, Armin Wolf wrote:
Add a new driver for Uniwill laptops. The driver uses a ACPI WMI
interface to talk with the embedded controller, but relies on a
DMI whitelist for autoloading since Uniwill just copied the WMI
GUID from the Windows driver example.
The driver is reverse-engineered based on the following information:
- OEM software from intel
- https://github.com/pobrn/qc71_laptop
- https://github.com/tuxedocomputers/tuxedo-drivers
- https://github.com/tuxedocomputers/tuxedo-control-center
The underlying EC supports various features, including hwmon sensors,
battery charge limiting, a RGB lightbar and keyboard-related controls.
Reported-by: cyear <chumuzero@xxxxxxxxx>
Closes: https://github.com/lm-sensors/lm-sensors/issues/508
Closes: https://github.com/Wer-Wolf/uniwill-laptop/issues/3
Signed-off-by: Armin Wolf <W_Armin@xxxxxx>
---
diff --git a/drivers/platform/x86/uniwill/Kconfig b/drivers/platform/x86/uniwill/Kconfig
index 5f1ea3e9e72f..57f9f88c757c 100644
--- a/drivers/platform/x86/uniwill/Kconfig
+++ b/drivers/platform/x86/uniwill/Kconfig
@@ -16,6 +16,23 @@ menuconfig X86_PLATFORM_DRIVERS_UNIWILL
if X86_PLATFORM_DRIVERS_UNIWILL
+config UNIWILL_LAPTOP
+ tristate "Uniwill Laptop Extras"
+ default m
+ depends on ACPI_WMI
+ depends on ACPI_BATTERY
+ depends on UNIWILL_WMI
+ depends on REGMAP
REGMAP is usually selected instead of being a dependency.
There is one other REGMAP dependency in the kernel tree vs. 131 selects.
Also, there is no user prompt for the REGMAP symbol so users aren't able
to enable it directly.
Or maybe you could select a more specific REGMAP_xyz and then it will
enable REGMAP:
config REGMAP
bool
default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM || REGMAP_MDIO || REGMAP_FSI)
Hi,
i am using a custom regmap backend, so i will go with just selecting REGMAP directly.
Thanks,
Armin Wolf
+ depends on HWMON
+ depends on LEDS_CLASS_MULTICOLOR
+ depends on DMI
+ help
+ This driver adds support for various extra features found on Uniwill laptops,
+ like the lightbar and hwmon sensors. It also supports many OEM laptops
+ originally manufactured by Uniwill.
+
+ If you have such a laptop, say Y or M here.
+
config UNIWILL_WMI
tristate "Uniwill WMI Event Driver"
default m
