Re: [PATCH v5 2/2] perf: Fujitsu: Add the Uncore PCI PMU driver

[Peter Zijlstra <peterz@xxxxxxxxxxxxx>]

On Tue, Jun 17, 2025 at 07:27:50PM +0900, Koichi Okuno wrote:
> +	pcipmu->pmu = (struct pmu) {
> +		.parent		= dev,
> +		.task_ctx_nr	= perf_invalid_context,
> +
> +		.pmu_enable	= fujitsu_pci__pmu_enable,
> +		.pmu_disable	= fujitsu_pci__pmu_disable,
> +		.event_init	= fujitsu_pci__event_init,
> +		.add		= fujitsu_pci__event_add,
> +		.del		= fujitsu_pci__event_del,
> +		.start		= fujitsu_pci__event_start,
> +		.stop		= fujitsu_pci__event_stop,
> +		.read		= fujitsu_pci__event_read,
> +
> +		.attr_groups	= fujitsu_pci_pmu_attr_grps,
> +		.capabilities	= PERF_PMU_CAP_NO_EXCLUDE,

Should these drivers not also have PERF_PMU_CAP_NO_INTERRUPT ? Per them
being uncore they cannot generate samples.

> +	};