On Sat, Jun 14, 2025 at 12:14:38AM -0700, Nicolin Chen wrote: > +/* Entry for iommufd_ctx::mt_mmap */ > +struct iommufd_mmap { > + struct iommufd_object *owner; > + > + /* Allocated start position in mt_mmap tree */ > + unsigned long startp; pgoff_t, looks like this is already in PAGE_SIZE units. > + /* Physical range for io_remap_pfn_range() */ > + unsigned long mmio_pfn; physaddr_t and maybe don't use pfn? > + unsigned long num_pfns; size_t Rest looks OK Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason