Hi Mark,
> On Wed, Jun 11, 2025 at 10:41:05AM +0100, Yeoreum Yun wrote:
> > Add the address tag [63:60] verification when synchronous mte fault is happen.
> > when signal handler is registered with SA_EXPOSE_TAGBITS,
> > address includes not only memory tag [59:56] but also address tag.
> > Therefore, when verify fault address location, remove both tags
>
> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
Thanks :D
> though if you're doing a new version there's minor stylistic stuff:
>
> > /* Compare the context for precise error */
> > else if (si->si_code == SEGV_MTESERR) {
> > + if ((!mtefar_support && si_atag) || (si_atag != MT_FETCH_ATAG(cur_mte_cxt.trig_addr))) {
> > + ksft_print_msg("Invalid MTE synchronous exception caught for address tag! si_tag=%x, si_atag: %x\n", si_tag, si_atag);
> > + exit(KSFT_FAIL);
> > + }
>
> Indentation seems off, also there's ksft_exit_fail_msg() but either way
> works.
I'll fix the indentation next round. Thanks to let me know.
--
Sincerely,
Yeoreum Yun
