Hi Reinette,
On 5/22/2025 11:33 AM, Reinette Chatre wrote:
Hi Babu,
On 5/22/25 8:44 AM, Moger, Babu wrote:
On 5/21/25 18:03, Reinette Chatre wrote:
...
This is why I proposed in [3] that the name of the mode reflects how user can interact
with the system. Instead of one "mbm_cntr_assign" mode there can be "mbm_cntr_event_assign"
that is used for ABMC and "mbm_cntr_group_assign" that is used for soft-ABMC. The mode should
make it clear what the system is capable of wrt counter assignments.
Yes, that makes sense. Perhaps we can also simplify it further:
# cat /sys/fs/resctrl/info/L3_MON/mbm_assign_mode:
[mbm_cntr_evt_assign] <- for ABMC
mbm_cntr_grp_assign <- for soft-ABMC
Looks good to me. Thank you.
I am actually ready with v14 series. I have good feeling that we are
getting closer to making these changes final.
So, Looking back again, it might make more sense to rename few user
visible interfaces.
1. # cat /sys/fs/resctrl/info/L3_MON/mbm_assign_mode.
[mbm_assign_event] <- for ABMC
mbm_assign_group <- for soft-ABMC
This looks much more cleaner. It matches with "mbm_assign_mode"
Similarly, we can rename few functions and variable names to make little
more readable.
2. mbm_cntr_assignable -> mbm_assignable
3. resctrl_arch_mbm_cntr_assign_enabled
-> >resctrl_arch_mbm_assign_enabled
4. mbm_cntr_assign_enabled -> mbm_assign_enabled
5. resctrl_arch_mbm_cntr_assign_set_one ->
resctrl_arch_mbm_assign_set_one.
6. There will few more functions. I will look into that if you agree
with approach.
7. No need to change few of these below. These are related to actual
counters.
num_mbm_cntrs
available_mbm_cntrs
What do you think?
Thanks
Babu Moger
