> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Larysa Zaremba > Sent: Friday, May 16, 2025 7:58 AM > To: intel-wired-lan@xxxxxxxxxxxxxxxx; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet > <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; Jonathan > Corbet <corbet@xxxxxxx>; Kitszel, Przemyslaw > <przemyslaw.kitszel@xxxxxxxxx>; Jiri Pirko <jiri@xxxxxxxxxxx>; Nikolova, Tatyana > E <tatyana.e.nikolova@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; > Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Michael Ellerman > <mpe@xxxxxxxxxxxxxx>; Fijalkowski, Maciej <maciej.fijalkowski@xxxxxxxxx>; > Lee Trager <lee@xxxxxxxxx>; Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>; > Zaremba, Larysa <larysa.zaremba@xxxxxxxxx>; Samudrala, Sridhar > <sridhar.samudrala@xxxxxxxxx>; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; > Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>; Polchlopek, > Mateusz <mateusz.polchlopek@xxxxxxxxx>; Zaki, Ahmed > <ahmed.zaki@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux- > doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Karlsson, Magnus > <magnus.karlsson@xxxxxxxxx>; Tantilov, Emil S <emil.s.tantilov@xxxxxxxxx>; > Chittim, Madhu <madhu.chittim@xxxxxxxxx>; Hay, Joshua A > <joshua.a.hay@xxxxxxxxx>; Olech, Milena <milena.olech@xxxxxxxxx>; Linga, > Pavan Kumar <pavan.kumar.linga@xxxxxxxxx>; Singhai, Anjali > <anjali.singhai@xxxxxxxxx>; Kubiak, Michal <michal.kubiak@xxxxxxxxx> > Subject: [Intel-wired-lan] [PATCH iwl-next v4 11/15] idpf: print a debug > message and bail in case of non-event ctlq message > > Unlike previous internal idpf ctlq implementation, idpf calls the default > message handler for all received messages that do not have a matching xn > transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error > messages printing garbage, because the parsing expected a valid event > message, but got e.g. a delayed response for a timed-out transaction. > > The information about timed-out transactions and otherwise unhandleable > messages can still be valuable for developers, so print the information with > dynamic debug and exit the function, so the following functions can parse > valid events in peace. > > Reviewed-by: Michal Kubiak <michal.kubiak@xxxxxxxxx> > Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx> > --- > 2.47.0 Tested-by: Samuel Salin <Samuel.salin@xxxxxxxxx>
