>From: Jakub Kicinski <kuba@xxxxxxxxxx> >Sent: Friday, May 30, 2025 2:33 AM > >On Fri, 23 May 2025 17:42:22 +0200 Arkadiusz Kubalewski wrote: >> +Phase offset measurement is typically performed against the current >>active >> +source. However, some DPLL (Digital Phase-Locked Loop) devices may offer >> +the capability to monitor phase offsets across all available inputs. >> +The attribute and current feature state shall be included in the >>response >> +message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL >>devices. >> +In such cases, users can also control the feature using the >> +``DPLL_CMD_DEVICE_SET`` command by setting the ``enum >>dpll_feature_state`` >> +values for the attribute. > >Since we're waiting for the merge window to be over - could you mention >the attribute the PHASE_OFFSET comes out as? DPLL_A_PIN_PHASE_OFFSET ? > Sure, will do in v5. >BTW I noticed that in the YAML spec, in a comment we say >DPLL_A_PHASE_OFFSET a couple of times, missing the _PIN. Hm, true, will try to prepare separated fix commit for those. Thank you! Arkadiusz
