Re: [PATCH] kernel-doc: Fix symbol matching for dropped suffixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 09, 2025 at 02:23:56PM -0600, Jonathan Corbet wrote:
> "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> writes:
> 
> > The support for dropping "_noprof" missed dropping the suffix from
> > exported symbols.  That meant that using the :export: feature would
> > look for kernel-doc for (eg) krealloc_noprof() and not find the
> > kernel-doc for krealloc().
> >
> > Fixes: 51a7bf0238c2 (scripts/kernel-doc: drop "_noprof" on function prototypes)
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> > ---
> >  scripts/lib/kdoc/kdoc_parser.py | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> I've applied this.  Naturally, it gifts us with a new docs build
> warning:
> 
> > Documentation/core-api/mm-api:40: ./mm/slub.c:4936: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> > Documentation/core-api/mm-api:40: ./mm/slub.c:4936: ERROR: Undefined substitution referenced: "--------". [docutils]
> 
> I was hoping your other slab patch series address this, but it doesn't
> look that way...?

Indeed it does.

It's a pre-existing bug, that's only unmaked by this patch.  Honestly,
I'm not that great at kerneldoc and I was hoping someone like Randy
would notice and fix it ;-)




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux