Hi Tony, On 5/28/25 16:41, Moger, Babu wrote: > Hi Tony, Peter, > > On 5/27/2025 4:41 PM, Luck, Tony wrote: >> >>> Thanks for applying my suggestion[1] about the array entry sizes, but >>> you needed one more dereference: >> >>> - size_t tsize = sizeof(hw_dom->arch_mbm_states[0]); >>> + size_t tsize = sizeof(*hw_dom->arch_mbm_states[0]); >> >>> - size_t tsize = sizeof(d->mbm_states[0]); >>> + size_t tsize = sizeof(*d->mbm_states[0]); >> >> Indeed yes. Thanks. >> > > Tony, Thanks for porting patches. > > I can actually pick your branch [1] and apply review comments on top for > v14 series. Hope that is fine with everyone. > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git/log/?h=my_mbm_plus_babu_abmc > > One question though: Where will the Peter's fix [2] go? > [2] > https://lore.kernel.org/lkml/CALPaoCj7FBv_vfDp+4tgqo4p8T7Eov_Ys+CQRoAX6u43a4OTDQ@xxxxxxxxxxxxxx/ > > thanks > Babu > > I'm currently working on v14 and plan to post the updated ABMC series tomorrow. I've used your multi-event support patches as the base: x86, fs/resctrl: Consolidate monitor event descriptions x86, fs/resctrl: Replace architecture event enabled checks x86/resctrl: Remove 'rdt_mon_features' global variable x86, fs/resctrl: Prepare for more monitor events I noticed there are a few comments on your series here: https://lore.kernel.org/lkml/20250521225049.132551-1-tony.luck@xxxxxxxxx/ Let me know if you've updated the patches. If so, I’ll incorporate the latest version. Otherwise, I’ll proceed with the current base as-is. -- Thanks Babu Moger
