OK a 'reviewlet' :P (have to say I like this terminology...) I see we are already ostensibly 'dynamic' in that hugepage_pmd_enabled() changes our algorithm. So my comments about dynamic alterting are probably not quite valid. Are we not in a weird situation where, with mTHP-only enabled we just use calculate_min_free_kbytes()?? That probably needs addressing (perhaps separately...) Lord I hate how we do this (not your fault!) Rest of review still applicable :>) Thanks for raising these important issues, while I am raising technical criticism of the patch, I do very much think you're identifying a real (and really very significant for those using v. large page table sizes) problem we need to address one way or another. Cheers, Lorenzo
