Re: [PATCH net-next v12 05/13] net: ethtool: Add support for new power domains index description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 24 May 2025 12:56:07 +0200 Kory Maincent wrote:
> +	if (st->pw_d_id > 0)

nit: here..

> +		len += nla_total_size(sizeof(u32)); /* _PSE_PW_D_ID */
>  	if (st->podl_admin_state > 0)
>  		len += nla_total_size(sizeof(u32)); /* _PODL_PSE_ADMIN_STATE */
>  	if (st->podl_pw_status > 0)
> @@ -148,6 +150,11 @@ static int pse_fill_reply(struct sk_buff *skb,
>  	const struct pse_reply_data *data = PSE_REPDATA(reply_base);
>  	const struct ethtool_pse_control_status *st = &data->status;
>  
> +	if (st->pw_d_id > 0 &&

and here -- it's unsigned so just if (st->pw_d_id &&
no need to add > 0




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux