Hi Babu,
On 5/28/25 9:56 AM, Moger, Babu wrote:
> On 5/22/2025 4:02 PM, Reinette Chatre wrote:
>> On 5/15/25 3:51 PM, Babu Moger wrote:
>>> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
>>> index bdb264875ef6..d77981d1fcb9 100644
>>> --- a/include/linux/resctrl.h
>>> +++ b/include/linux/resctrl.h
>>> @@ -156,6 +156,20 @@ struct rdt_ctrl_domain {
>>> u32 *mbps_val;
>>> };
>>> +/**
>>> + * struct mbm_cntr_cfg - Assignable counter configuration
>>> + * @evtid: MBM event to which the counter is assigned. Only valid
>>> + * if @rdtgroup is not NULL.
>>> + * @evt_cfg: Event configuration value.
>>
>> @evt_cfg is not introduced in changelog nor defined here. Please add a snippet here
>> on what @evt_cfg's values represent. This is important since this is exposed
>> as resctrl fs API to architectures so all architectures need to use same values when
>> interacting with resctrl.
>
> Sure.
>
> @evt_cfg: A value that represents memory transactions (e.g., reads, writes, etc.).
This still does not explain how an @evt_cfg value should be interpreted. For example, it
could be something like below (please feel free to improve).
@evt_cfg: Event configuration created using the READS_TO_LOCAL_MEM, READS_TO_REMOTE_MEM, etc. bits
that represent the memory transactions being counted.
Reinette
