> -----Original Message----- > From: Paolo Abeni <pabeni@xxxxxxxxxx> > Sent: Tuesday, May 20, 2025 3:38 PM > To: Eric Dumazet <edumazet@xxxxxxxxxx>; Chia-Yu Chang (Nokia) <chia-yu.chang@xxxxxxxxxxxxxxxxxxx> > Cc: linux-doc@xxxxxxxxxxxxxxx; corbet@xxxxxxx; horms@xxxxxxxxxx; dsahern@xxxxxxxxxx; kuniyu@xxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; dave.taht@xxxxxxxxx; jhs@xxxxxxxxxxxx; kuba@xxxxxxxxxx; stephen@xxxxxxxxxxxxxxxxxx; xiyou.wangcong@xxxxxxxxx; jiri@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; andrew+netdev@xxxxxxx; donald.hunter@xxxxxxxxx; ast@xxxxxxxxxxx; liuhangbin@xxxxxxxxx; shuah@xxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; ij@xxxxxxxxxx; ncardwell@xxxxxxxxxx; Koen De Schepper (Nokia) <koen.de_schepper@xxxxxxxxxxxxxxxxxxx>; g.white <g.white@xxxxxxxxxxxxx>; ingemar.s.johansson@xxxxxxxxxxxx; mirja.kuehlewind@xxxxxxxxxxxx; cheshire@xxxxxxxxx; rs.ietf@xxxxxx; Jason_Livingood@xxxxxxxxxxx; vidhi_goel <vidhi_goel@xxxxxxxxx> > Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option > > > CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information. > > > > On 5/20/25 12:32 PM, Eric Dumazet wrote: > > On Tue, May 20, 2025 at 2:31 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > >> > >> On 5/14/25 3:56 PM, chia-yu.chang@xxxxxxxxxxxxxxxxxxx wrote: > >>> This patch uses the existing 1-byte holes in the tcp_sock_write_txrx > >>> group for new u8 members, but adds a 4-byte hole in > >>> tcp_sock_write_rx group after the new u32 delivered_ecn_bytes[3] > >>> member. Therefore, the group size of tcp_sock_write_rx is increased from 96 to 112. > >> > >> Note that I'm still concerned by the relevant increase of the > >> cacheline groups size. My fear is that this change could defeat > >> some/most of the benefist from the cacheline reorg for all tcp users. > >> > >> Some additional feedback from Eric and/or Neal more than welcome! > > > > I have been trapped lately with production issues, sorry for the delay. > > > > I am still working on an idpf bug, hopefully done today. > > > > Then, I am OOO tomorrow, and can have a look at the whole series on Thursday. > > Thanks Eric! > > @Chia-Yu: please consider the above timeline before posting a new revision. i.e. it would be likely wise to wait for the additional review. > > /P Hi Eric and Paolo, As you know that the merge window for v6.16 is begun and net-next is closed for new features till 9th of June. May I ask did you manage yo review the patches we sent two weeks ago? Thanks. Best Regards, Chia-Yu
