On 5/23/25 5:42 PM, Arkadiusz Kubalewski wrote:
> Add dpll device level feature: phase offset monitor.
>
> Phase offset measurement is typically performed against the current active
> source. However, some DPLL (Digital Phase-Locked Loop) devices may offer
> the capability to monitor phase offsets across all available inputs.
> The attribute and current feature state shall be included in the response
> message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL devices.
> In such cases, users can also control the feature using the
> ``DPLL_CMD_DEVICE_SET`` command by setting the ``enum dpll_feature_state``
> values for the attribute.
>
> Implement feature support in ice driver for dpll-enabled devices.
>
> Verify capability:
> $ ./tools/net/ynl/pyynl/cli.py \
> --spec Documentation/netlink/specs/dpll.yaml \
> --dump device-get
> [{'clock-id': 4658613174691613800,
> 'id': 0,
> 'lock-status': 'locked-ho-acq',
> 'mode': 'automatic',
> 'mode-supported': ['automatic'],
> 'module-name': 'ice',
> 'type': 'eec'},
> {'clock-id': 4658613174691613800,
> 'id': 1,
> 'lock-status': 'locked-ho-acq',
> 'mode': 'automatic',
> 'mode-supported': ['automatic'],
> 'module-name': 'ice',
> 'phase-offset-monitor': 'disable',
> 'type': 'pps'}]
>
> Enable the feature:
> $ ./tools/net/ynl/pyynl/cli.py \
> --spec Documentation/netlink/specs/dpll.yaml \
> --do device-set --json '{"id":1, "phase-offset-monitor":"enable"}'
>
> Verify feature is enabled:
> $ ./tools/net/ynl/pyynl/cli.py \
> --spec Documentation/netlink/specs/dpll.yaml \
> --dump device-get
> [
> [...]
> {'capabilities': {'all-inputs-phase-offset-monitor'},
> 'clock-id': 4658613174691613800,
> 'id': 1,
> [...]
> 'phase-offset-monitor': 'enable',
> [...]]
I'm sorry, even if this has been posted (just) before the merge window,
I think an uAPI extension this late is a bit too dangerous, please
repost when net-next reopen after the merge window.
Thanks,
Paolo
