Hi Laurent, On Mon, May 26, 2025 at 01:48:02PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. Thank you for the review. > > On Mon, May 26, 2025 at 02:17:31PM +0300, Sakari Ailus wrote: > > The Media Controller uses IOCTL numbers up to 0x81. Given that nothing > > appears to be using them for other purposes, even in the samples > > allocation (checked with $ git grep "#define.*_IO.*'|'"), just reassign > > the numbers up to 0x8f to linux/media.h and bump the samples allocation by > > 0x10. > > The commit message should explain why. The explanation is in the cover > letter, just move it to this patch. With that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I'll use this in v2: The Media Controller uses IOCTL type '|' with numbers up to 0x81 while numbers from 0x80 onwards are allocated for samples, creating a conflict between allocations for MC and samples. Given that nothing appears to be using numbers between 0x80 and 0x8f for other purposes than MC, even in the samples allocation (checked with $ git grep "#define.*_IO.*'|'"), just reassign the numbers up to 0x8f to linux/media.h and bump the samples allocation by 0x10. > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > Documentation/userspace-api/ioctl/ioctl-number.rst | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst > > index bc91756bde73..6b3be3fb0b15 100644 > > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst > > @@ -312,8 +312,8 @@ Code Seq# Include File Comments > > 'z' 40-7F CAN bus card conflict! > > <mailto:oe@xxxxxxx> > > 'z' 10-4F drivers/s390/crypto/zcrypt_api.h conflict! > > -'|' 00-7F linux/media.h > > -'|' 80-9F samples/ Any sample and example drivers > > +'|' 00-8F linux/media.h > > +'|' 90-AF samples/ Any sample and example drivers > > 0x80 00-1F linux/fb.h > > 0x81 00-1F linux/vduse.h > > 0x89 00-06 arch/x86/include/asm/sockios.h > -- Regards, Sakari Ailus
