On Tue, May 20, 2025 at 05:27:37PM -0500, Rob Herring (Arm) wrote: > From: Anshuman Khandual <anshuman.khandual@xxxxxxx> > > Commit 5b39db6037e7 ("arm64: el2_setup.h: Rename some labels to be more > diff-friendly") reworked the labels in __init_el2_fgt to say what's > skipped rather than what the target location is. The exception was > "set_fgt_" which is where registers are written. In reviewing the BRBE > additions, Will suggested "set_debug_fgt_" where HDFGxTR_EL2 are > written. Doing that would partially revert commit 5b39db6037e7 undoing > the goal of minimizing additions here, but it would follow the > convention for labels where registers are written. > > So let's do both. Branches that skip something go to a "skip" label and > places that set registers have a "set" label. This results in some > double labels, but it makes things entirely consistent. > > While we're here, the SME skip label was incorrectly named, so fix it. > > Reported-by: Will Deacon <will@xxxxxxxxxx> > Cc: Dave Martin <Dave.Martin@xxxxxxx> > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > --- > This one can be applied even if the rest of the series is not. Cheers, Rob. I'll grab this one. Will