On 21/05/2025 1:59, Jakub Kicinski wrote:
On Tue, 20 May 2025 21:38:03 +0300 Tariq Toukan wrote:
Test verifies that netdevsim correctly implements devlink ops callbacks
that set tc-bw on leaf or node rate object.
Please add a test that can actually validate a NIC HW.
The test probably needs to be in Python to use a remote endpoint,
and should live under tools/testing/../drivers/net/hw
We had a long conversation about what we expect from the API
vs how your HW works. One of the test cases should confirm
the expected behavior, IOW fail on mlx5. Which is fine,
unlikely that any NIC will have 100% compliance. But at
least we will be documenting the expectations.
No problem with that, we'll add.
We could've saved this extra cycle if my questions [1] exactly about
this topic weren't ignored.
Area is vague and not well defined. We can continue with the iterative
guess and fix cycles, or alternatively get it clearly and formally defined.
[1]
https://lore.kernel.org/all/98386cab-11c0-4f74-9925-8230af2e65c8@xxxxxxxxx/
