On Mon, 19 May 2025 12:19:28 +0300 Gur Stavi wrote:
> + if (unlikely(hinic3_wq_free_wqebbs(&txq->sq->wq) < wqebb_cnt)) {
> + if (likely(wqebb_cnt > txq->tx_stop_thrs))
> + txq->tx_stop_thrs = min(wqebb_cnt, txq->tx_start_thrs);
> +
> + netif_subqueue_try_stop(netdev, tx_q->sq->q_id,
> + hinic3_wq_free_wqebbs(&tx_q->sq->wq),
> + tx_q->tx_start_thrs);
> +
> + return -NETDEV_TX_BUSY;
Why flip the value to negative here?
Should be just:
return NETDEV_TX_BUSY;
right?
The rest looks good.
--
pw-bot: cr
