Extend the interrupt handler to process interrupts as inactivity events. Add functions to set threshold and period registers for inactivity. Add functions to enable / disable inactivity. Extend the fake iio channel to deal with inactivity events on x, y and z combined with AND. Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx> --- drivers/iio/accel/adxl313.h | 2 + drivers/iio/accel/adxl313_core.c | 98 +++++++++++++++++++++++++++++++- 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/adxl313.h b/drivers/iio/accel/adxl313.h index 9c7aedf7da7a..1398ac54d19b 100644 --- a/drivers/iio/accel/adxl313.h +++ b/drivers/iio/accel/adxl313.h @@ -18,6 +18,8 @@ #define ADXL313_REG_SOFT_RESET 0x18 #define ADXL313_REG_OFS_AXIS(index) (0x1E + (index)) #define ADXL313_REG_THRESH_ACT 0x24 +#define ADXL313_REG_THRESH_INACT 0x25 +#define ADXL313_REG_TIME_INACT 0x26 #define ADXL313_REG_ACT_INACT_CTL 0x27 #define ADXL313_REG_BW_RATE 0x2C #define ADXL313_REG_POWER_CTL 0x2D diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c index 49914ccc92cf..46ca30abc7fd 100644 --- a/drivers/iio/accel/adxl313_core.c +++ b/drivers/iio/accel/adxl313_core.c @@ -28,18 +28,22 @@ #define ADXL313_REG_XYZ_BASE ADXL313_REG_DATA_AXIS(0) #define ADXL313_ACT_XYZ_EN GENMASK(6, 4) +#define ADXL313_INACT_XYZ_EN GENMASK(2, 0) /* activity/inactivity */ enum adxl313_activity_type { ADXL313_ACTIVITY, + ADXL313_INACTIVITY, }; static const unsigned int adxl313_act_int_reg[] = { [ADXL313_ACTIVITY] = ADXL313_INT_ACTIVITY, + [ADXL313_INACTIVITY] = ADXL313_INT_INACTIVITY, }; static const unsigned int adxl313_act_thresh_reg[] = { [ADXL313_ACTIVITY] = ADXL313_REG_THRESH_ACT, + [ADXL313_INACTIVITY] = ADXL313_REG_THRESH_INACT, }; static const struct regmap_range adxl312_readable_reg_range[] = { @@ -254,6 +258,14 @@ static const struct iio_event_spec adxl313_fake_chan_events[] = { .mask_separate = BIT(IIO_EV_INFO_ENABLE), .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE), }, + { + /* inactivity */ + .type = IIO_EV_TYPE_MAG, + .dir = IIO_EV_DIR_FALLING, + .mask_separate = BIT(IIO_EV_INFO_ENABLE), + .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_PERIOD), + }, }; enum adxl313_chans { @@ -334,6 +346,15 @@ static int adxl313_read_freq_avail(struct iio_dev *indio_dev, } } +static int adxl313_set_inact_time_s(struct adxl313_data *data, + unsigned int val_s) +{ + unsigned int max_boundary = 255; + unsigned int val = min(val_s, max_boundary); + + return regmap_write(data->regmap, ADXL313_REG_TIME_INACT, val); +} + static int adxl313_is_act_inact_en(struct adxl313_data *data, enum adxl313_activity_type type, bool *en) @@ -350,6 +371,8 @@ static int adxl313_is_act_inact_en(struct adxl313_data *data, if (type == ADXL313_ACTIVITY) *en = FIELD_GET(ADXL313_ACT_XYZ_EN, axis_ctrl); + else + *en = FIELD_GET(ADXL313_INACT_XYZ_EN, axis_ctrl); if (*en) { ret = regmap_read(data->regmap, ADXL313_REG_INT_ENABLE, ®val); @@ -366,13 +389,16 @@ static int adxl313_set_act_inact_en(struct adxl313_data *data, enum adxl313_activity_type type, bool cmd_en) { - unsigned int axis_ctrl = 0; + unsigned int axis_ctrl; unsigned int threshold; + unsigned int inact_time_s; bool en; int ret; if (type == ADXL313_ACTIVITY) axis_ctrl = ADXL313_ACT_XYZ_EN; + else + axis_ctrl = ADXL313_INACT_XYZ_EN; ret = regmap_update_bits(data->regmap, ADXL313_REG_ACT_INACT_CTL, @@ -387,8 +413,15 @@ static int adxl313_set_act_inact_en(struct adxl313_data *data, en = false; - if (type == ADXL313_ACTIVITY) + if (type == ADXL313_ACTIVITY) { en = cmd_en && threshold; + } else { + ret = regmap_read(data->regmap, ADXL313_REG_TIME_INACT, &inact_time_s); + if (ret) + return ret; + + en = cmd_en && threshold && inact_time_s; + } return regmap_update_bits(data->regmap, ADXL313_REG_INT_ENABLE, adxl313_act_int_reg[type], @@ -487,6 +520,13 @@ static int adxl313_read_event_config(struct iio_dev *indio_dev, if (ret) return ret; return int_en; + case IIO_EV_DIR_FALLING: + ret = adxl313_is_act_inact_en(data, + ADXL313_INACTIVITY, + &int_en); + if (ret) + return ret; + return int_en; default: return -EINVAL; } @@ -510,6 +550,10 @@ static int adxl313_write_event_config(struct iio_dev *indio_dev, return adxl313_set_act_inact_en(data, ADXL313_ACTIVITY, state); + case IIO_EV_DIR_FALLING: + return adxl313_set_act_inact_en(data, + ADXL313_INACTIVITY, + state); default: return -EINVAL; } @@ -527,6 +571,8 @@ static int adxl313_read_event_value(struct iio_dev *indio_dev, { struct adxl313_data *data = iio_priv(indio_dev); unsigned int act_threshold; + unsigned int inact_threshold; + unsigned int inact_time_s; int ret; /* measurement stays enabled, reading from regmap cache */ @@ -545,9 +591,26 @@ static int adxl313_read_event_value(struct iio_dev *indio_dev, *val = act_threshold * 15625; *val2 = 1000000; return IIO_VAL_FRACTIONAL; + case IIO_EV_DIR_FALLING: + ret = regmap_read(data->regmap, + adxl313_act_thresh_reg[ADXL313_INACTIVITY], + &inact_threshold); + if (ret) + return ret; + *val = inact_threshold * 15625; + *val2 = 1000000; + return IIO_VAL_FRACTIONAL; default: return -EINVAL; } + case IIO_EV_INFO_PERIOD: + ret = regmap_read(data->regmap, + ADXL313_REG_TIME_INACT, + &inact_time_s); + if (ret) + return ret; + *val = inact_time_s; + return IIO_VAL_INT; default: return -EINVAL; } @@ -586,9 +649,21 @@ static int adxl313_write_event_value(struct iio_dev *indio_dev, if (ret) return ret; return adxl313_set_measure_en(data, true); + case IIO_EV_DIR_FALLING: + ret = regmap_write(data->regmap, + adxl313_act_thresh_reg[ADXL313_INACTIVITY], + regval); + if (ret) + return ret; + return adxl313_set_measure_en(data, true); default: return -EINVAL; } + case IIO_EV_INFO_PERIOD: + ret = adxl313_set_inact_time_s(data, val); + if (ret) + return ret; + return adxl313_set_measure_en(data, true); default: return -EINVAL; } @@ -747,6 +822,17 @@ static int adxl313_push_event(struct iio_dev *indio_dev, int int_stat) return ret; } + if (FIELD_GET(ADXL313_INT_INACTIVITY, int_stat)) { + ret = iio_push_event(indio_dev, + IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, + IIO_MOD_X_AND_Y_AND_Z, + IIO_EV_TYPE_MAG, + IIO_EV_DIR_FALLING), + ts); + if (ret) + return ret; + } + if (FIELD_GET(ADXL313_INT_WATERMARK, int_stat)) { samples = adxl313_get_samples(data); if (samples < 0) @@ -916,6 +1002,14 @@ int adxl313_core_probe(struct device *dev, if (ret) return ret; + ret = regmap_write(data->regmap, ADXL313_REG_TIME_INACT, 5); + if (ret) + return ret; + + ret = regmap_write(data->regmap, ADXL313_REG_THRESH_INACT, 0x4f); + if (ret) + return ret; + ret = regmap_write(data->regmap, ADXL313_REG_THRESH_ACT, 0x52); if (ret) return ret; -- 2.39.5