Hi Chiang, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on groeck-staging/hwmon-next krzk-dt/for-next linus/master v6.15-rc6 next-20250515] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chiang-Brian/hwmon-pmbus-tps53679-Add-support-for-TPS53685/20250515-171511 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20250515081449.1433772-3-chiang.brian%40inventec.com patch subject: [PATCH v7 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 config: i386-buildonly-randconfig-001-20250516 (https://download.01.org/0day-ci/archive/20250516/202505161242.oQFhPxZ9-lkp@xxxxxxxxx/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250516/202505161242.oQFhPxZ9-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202505161242.oQFhPxZ9-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/hwmon/pmbus/tps53679.c:133:50: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'char *' [-Wint-conversion] 133 | ret = tps53679_identify_chip(client, pmbus_rev, device_id); | ^~~~~~~~~ drivers/hwmon/pmbus/tps53679.c:90:26: note: passing argument to parameter 'id' here 90 | u8 revision, char *id) | ^ >> drivers/hwmon/pmbus/tps53679.c:165:10: error: incompatible pointer to integer conversion passing 'char[2]' to parameter of type 'int' [-Wint-conversion] 165 | TPS53681_DEVICE_ID); | ^~~~~~~~~~~~~~~~~~ drivers/hwmon/pmbus/tps53679.c:34:32: note: expanded from macro 'TPS53681_DEVICE_ID' 34 | #define TPS53681_DEVICE_ID "\x81" | ^~~~~~ drivers/hwmon/pmbus/tps53679.c:129:25: note: passing argument to parameter 'device_id' here 129 | int pmbus_rev, int device_id) | ^ 2 errors generated. vim +133 drivers/hwmon/pmbus/tps53679.c 53030bcc87e4a4b Guenter Roeck 2020-01-20 120 53030bcc87e4a4b Guenter Roeck 2020-01-20 121 /* 53030bcc87e4a4b Guenter Roeck 2020-01-20 122 * Common identification function for chips with multi-phase support. 53030bcc87e4a4b Guenter Roeck 2020-01-20 123 * Since those chips have special configuration registers, we want to have 53030bcc87e4a4b Guenter Roeck 2020-01-20 124 * some level of reassurance that we are really talking with the chip 53030bcc87e4a4b Guenter Roeck 2020-01-20 125 * being probed. Check PMBus revision and chip ID. 53030bcc87e4a4b Guenter Roeck 2020-01-20 126 */ 53030bcc87e4a4b Guenter Roeck 2020-01-20 127 static int tps53679_identify_multiphase(struct i2c_client *client, 53030bcc87e4a4b Guenter Roeck 2020-01-20 128 struct pmbus_driver_info *info, 53030bcc87e4a4b Guenter Roeck 2020-01-20 129 int pmbus_rev, int device_id) 53030bcc87e4a4b Guenter Roeck 2020-01-20 130 { 53030bcc87e4a4b Guenter Roeck 2020-01-20 131 int ret; 53030bcc87e4a4b Guenter Roeck 2020-01-20 132 53030bcc87e4a4b Guenter Roeck 2020-01-20 @133 ret = tps53679_identify_chip(client, pmbus_rev, device_id); 53030bcc87e4a4b Guenter Roeck 2020-01-20 134 if (ret < 0) 53030bcc87e4a4b Guenter Roeck 2020-01-20 135 return ret; 53030bcc87e4a4b Guenter Roeck 2020-01-20 136 53030bcc87e4a4b Guenter Roeck 2020-01-20 137 ret = tps53679_identify_mode(client, info); 53030bcc87e4a4b Guenter Roeck 2020-01-20 138 if (ret < 0) 53030bcc87e4a4b Guenter Roeck 2020-01-20 139 return ret; 53030bcc87e4a4b Guenter Roeck 2020-01-20 140 53030bcc87e4a4b Guenter Roeck 2020-01-20 141 return tps53679_identify_phases(client, info); 53030bcc87e4a4b Guenter Roeck 2020-01-20 142 } 53030bcc87e4a4b Guenter Roeck 2020-01-20 143 53030bcc87e4a4b Guenter Roeck 2020-01-20 144 static int tps53679_identify(struct i2c_client *client, 53030bcc87e4a4b Guenter Roeck 2020-01-20 145 struct pmbus_driver_info *info) 53030bcc87e4a4b Guenter Roeck 2020-01-20 146 { 53030bcc87e4a4b Guenter Roeck 2020-01-20 147 return tps53679_identify_mode(client, info); 53030bcc87e4a4b Guenter Roeck 2020-01-20 148 } 53030bcc87e4a4b Guenter Roeck 2020-01-20 149 340e957083852e1 Chiang Brian 2025-05-15 150 static int tps53685_identify(struct i2c_client *client, 340e957083852e1 Chiang Brian 2025-05-15 151 struct pmbus_driver_info *info) 340e957083852e1 Chiang Brian 2025-05-15 152 { 340e957083852e1 Chiang Brian 2025-05-15 153 info->func[1] |= PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | 340e957083852e1 Chiang Brian 2025-05-15 154 PMBUS_HAVE_STATUS_INPUT; 340e957083852e1 Chiang Brian 2025-05-15 155 info->format[PSC_VOLTAGE_OUT] = linear; 340e957083852e1 Chiang Brian 2025-05-15 156 return tps53679_identify_chip(client, TPS53681_PMBUS_REVISION, 340e957083852e1 Chiang Brian 2025-05-15 157 TPS53685_DEVICE_ID); 340e957083852e1 Chiang Brian 2025-05-15 158 } 340e957083852e1 Chiang Brian 2025-05-15 159 53030bcc87e4a4b Guenter Roeck 2020-01-20 160 static int tps53681_identify(struct i2c_client *client, 53030bcc87e4a4b Guenter Roeck 2020-01-20 161 struct pmbus_driver_info *info) 53030bcc87e4a4b Guenter Roeck 2020-01-20 162 { 53030bcc87e4a4b Guenter Roeck 2020-01-20 163 return tps53679_identify_multiphase(client, info, 53030bcc87e4a4b Guenter Roeck 2020-01-20 164 TPS53681_PMBUS_REVISION, 53030bcc87e4a4b Guenter Roeck 2020-01-20 @165 TPS53681_DEVICE_ID); 53030bcc87e4a4b Guenter Roeck 2020-01-20 166 } 53030bcc87e4a4b Guenter Roeck 2020-01-20 167 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki