Re: [PATCH net-next v5 5/5] eth: fbnic: Add devlink dev flash support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/12/25 8:54 PM, Lee Trager wrote:
> +static int
> +fbnic_flash_start(struct fbnic_dev *fbd, struct pldmfw_component *component)
> +{
> +	struct fbnic_fw_completion *cmpl;
> +	int err;
> +
> +	cmpl = kzalloc(sizeof(*cmpl), GFP_KERNEL);
> +	if (!cmpl)
> +		return -ENOMEM;
> +
> +	fbnic_fw_init_cmpl(cmpl, FBNIC_TLV_MSG_ID_FW_START_UPGRADE_REQ);

Minor note for a possible follow-up: since completion allocation is
always followed by fbnic_fw_init_cmpl(), you could boundle the 2 in some
helper.

No need to repost for this.

/P





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux