Hi Derek, kernel test robot noticed the following build errors: [auto build test ERROR on amd-pstate/linux-next] [also build test ERROR on amd-pstate/bleeding-edge linus/master v6.15-rc6 next-20250512] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Derek-J-Clark/platform-x86-Add-lenovo-wmi-driver-Documentation/20250509-075718 base: https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next patch link: https://lore.kernel.org/r/20250508235217.12256-7-derekjohn.clark%40gmail.com patch subject: [PATCH v9 6/6] platform/x86: Add Lenovo Other Mode WMI Driver config: i386-randconfig-002-20250513 (https://download.01.org/0day-ci/archive/20250513/202505131340.eLNt4D5G-lkp@xxxxxxxxx/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250513/202505131340.eLNt4D5G-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202505131340.eLNt4D5G-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/platform/x86/lenovo-wmi-other.c:510:8: error: call to undeclared function 'MKDEV'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 510 | MKDEV(0, 0), NULL, "%s-%u", | ^ 1 error generated. vim +/MKDEV +510 drivers/platform/x86/lenovo-wmi-other.c 493 494 /** 495 * lwmi_om_fw_attr_add() - Register all firmware_attributes_class members 496 * @priv: The Other Mode driver data. 497 * 498 * Return: Either 0, or an error code. 499 */ 500 static int lwmi_om_fw_attr_add(struct lwmi_om_priv *priv) 501 { 502 unsigned int i; 503 int err; 504 505 priv->ida_id = ida_alloc(&lwmi_om_ida, GFP_KERNEL); 506 if (priv->ida_id < 0) 507 return priv->ida_id; 508 509 priv->fw_attr_dev = device_create(&firmware_attributes_class, NULL, > 510 MKDEV(0, 0), NULL, "%s-%u", 511 LWMI_OM_FW_ATTR_BASE_PATH, 512 priv->ida_id); 513 if (IS_ERR(priv->fw_attr_dev)) { 514 err = PTR_ERR(priv->fw_attr_dev); 515 goto err_free_ida; 516 } 517 518 priv->fw_attr_kset = kset_create_and_add("attributes", NULL, 519 &priv->fw_attr_dev->kobj); 520 if (!priv->fw_attr_kset) { 521 err = -ENOMEM; 522 goto err_destroy_classdev; 523 } 524 525 for (i = 0; i < ARRAY_SIZE(cd01_attr_groups) - 1; i++) { 526 err = sysfs_create_group(&priv->fw_attr_kset->kobj, 527 cd01_attr_groups[i].attr_group); 528 if (err) 529 goto err_remove_groups; 530 531 cd01_attr_groups[i].tunable_attr->dev = &priv->wdev->dev; 532 } 533 return 0; 534 535 err_remove_groups: 536 while (i--) 537 sysfs_remove_group(&priv->fw_attr_kset->kobj, 538 cd01_attr_groups[i].attr_group); 539 540 kset_unregister(priv->fw_attr_kset); 541 542 err_destroy_classdev: 543 device_unregister(priv->fw_attr_dev); 544 545 err_free_ida: 546 ida_free(&lwmi_om_ida, priv->ida_id); 547 return err; 548 } 549 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
