On May 3, 2025 2:42:38 AM PDT, ALOK TIWARI <alok.a.tiwari@xxxxxxxxxx> wrote: >Hi Derek, > >Thanks for your patch. > >On 03-05-2025 05:31, Derek J. Clark wrote: >> + attribute_id = >> + FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) | >> + FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) | >> + FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, LWMI_GZ_THERMAL_MODE_CUSTOM) | >> + FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id); >> + >> + //capdata = devm_kzalloc(&priv->wdev->dev, sizeof(*capdata), GFP_KERNEL); >> + //if (!capdata) >> + // return -ENOMEM; > >remove this dead code > Woops... thanks. Are you planning on reviewing the other 4 patches? If not I'll fix these up and send an update today. Cheers, Derek >> + >> + ret = lwmi_cd01_get_data(priv->cd01_list, attribute_id, &capdata); >> + if (ret) >> + return ret; > > >Reviewed-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx> > >Thanks, >Alok - Derek
