On Wed, Apr 30, 2025 at 08:38:06AM -0700, Guenter Roeck wrote: > On 4/30/25 07:36, Thomas Weißschuh wrote: > > On 2025-04-30 09:51:03+0800, Sung-Chi Li wrote: > > > On Tue, Apr 29, 2025 at 10:45:56PM +0200, Thomas Weißschuh wrote: > > > > On 2025-04-29 16:14:23+0800, Sung-Chi Li via B4 Relay wrote: > > > > > From: Sung-Chi Li <lschyi@xxxxxxxxxxxx> > > > > > > > > > > Register fans connected under EC as thermal cooling devices as well, so > > > > > these fans can then work with the thermal framework. > > > > > > > > > > During the driver probing phase, we will also try to register each fan > > > > > as a thermal cooling device based on previous probe result (whether the > > > > > there are fans connected on that channel, and whether EC supports fan > > > > > control). The basic get max state, get current state, and set current > > > > > state methods are then implemented as well. > > > > > > > > There is also HWMON_C_REGISTER_TZ, however it depends on OF. > > > > But this patch looks very generic, so maybe it makes sense to implement > > > > it in the hwmon core. > > > > > > > > > > Hi, the HWMON_C_REGISTER_TZ is for registering a thermal sensor, and here I > > > registered it as thermal cooling devices, so they are different. I followed > > > other hwmon drivers: > > > > > > - gpio-fan.c > > > - aspeed-pwm-tacho.c > > > - max6650.c > > > - qnap-mcu-hwmon.c > > > - ... > > > > Indeed, sorry. > > > > > . These hwmon drivers also manually registered other cooling devices, and that > > > makes sense to me, so I think it is good to just register cooling devices rather > > > than make big changes to hwmon core. > > > > The implementation does look like a lot of boilerplate. > > If Guenter doesn't chime in, let's stick with the current approach. > > > > Someone could make the necessary improvements to the hwmon core and clean up the drivers > implementing that boilerplate today, but that should be a separate patch series, and this > series should not depend on it. > > Patches welcome ... > > Thanks, > Guenter > Thank you, I will first complete this series, and see how to improve hwmon core afterwards.
