Hi,
On Thu, Apr 24, 2025 at 03:27:46PM +0100, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> After the previous patch, there are no implementers of the
> send_offchannel() and trysend_offchannel() methods.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---
> drivers/rpmsg/rpmsg_internal.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h
> index 42c7007be1b5..397e4926bd02 100644
> --- a/drivers/rpmsg/rpmsg_internal.h
> +++ b/drivers/rpmsg/rpmsg_internal.h
> @@ -50,10 +50,8 @@ struct rpmsg_device_ops {
> * @destroy_ept: see @rpmsg_destroy_ept(), required
> * @send: see @rpmsg_send(), required
> * @sendto: see @rpmsg_sendto(), optional
> - * @send_offchannel: see @rpmsg_send_offchannel(), optional
> * @trysend: see @rpmsg_trysend(), required
> * @trysendto: see @rpmsg_trysendto(), optional
> - * @trysend_offchannel: see @rpmsg_trysend_offchannel(), optional
> * @poll: see @rpmsg_poll(), optional
> * @set_flow_control: see @rpmsg_set_flow_control(), optional
> * @get_mtu: see @rpmsg_get_mtu(), optional
> @@ -67,13 +65,9 @@ struct rpmsg_endpoint_ops {
>
> int (*send)(struct rpmsg_endpoint *ept, void *data, int len);
> int (*sendto)(struct rpmsg_endpoint *ept, void *data, int len, u32 dst);
> - int (*send_offchannel)(struct rpmsg_endpoint *ept, u32 src, u32 dst,
> - void *data, int len);
>
> int (*trysend)(struct rpmsg_endpoint *ept, void *data, int len);
> int (*trysendto)(struct rpmsg_endpoint *ept, void *data, int len, u32 dst);
> - int (*trysend_offchannel)(struct rpmsg_endpoint *ept, u32 src, u32 dst,
> - void *data, int len);
> __poll_t (*poll)(struct rpmsg_endpoint *ept, struct file *filp,
> poll_table *wait);
> int (*set_flow_control)(struct rpmsg_endpoint *ept, bool pause, u32 dst);
I'm good with this patchset. Can you fix the last paragraph in the comment for
function rpmsg_send_offchannel_raw() and remove the reference to "_offchannel"?
Thanks,
Mathieu
> --
> 2.49.0
>
