On 29-04-2025 11:05 pm, Joe Perches wrote: > On Tue, 2025-04-29 at 16:07 +0000, Aditya Garg wrote: >> %p4cn was recently removed and replaced by %p4chR in vsprintf. So, >> remove the check for %p4cn from checkpatch.pl. >> >> Fixes: 37eed892cc5f ("vsprintf: Use %p4chR instead of %p4cn for reading data in reversed host ordering") >> >> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx> >> --- >> scripts/checkpatch.pl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 44e233b6f..f79f0a085 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -6891,7 +6891,7 @@ sub process { >> ($extension eq "f" && >> defined $qualifier && $qualifier !~ /^w/) || >> ($extension eq "4" && >> - defined $qualifier && $qualifier !~ /^c[hnlbc]/)) { >> + defined $qualifier && $qualifier !~ /^c[hlbc]/)) { > > Probably needs to be something like: > > $qualifier !~ /^c(?:[hlbc]|cR)$/ $qualifier !~ /^c(?:[hlbc]|hR)$/ I'll send a v2 > >> $bad_specifier = $specifier; >> last; >> } >