On 4/22/25 4:56 PM, Kory Maincent wrote: > @@ -223,6 +237,17 @@ struct pse_pi_pairset { > * @rdev: regulator represented by the PSE PI > * @admin_state_enabled: PI enabled state > * @pw_d: Power domain of the PSE PI > + * @prio: Priority of the PSE PI. Used in static budget evaluation strategy > + * @isr_pd_detected: PSE PI detection status managed by the interruption > + * handler. This variable is relevant when the power enabled > + * management is managed in software like the static > + * budget evaluation strategy. > + * @pw_allocated_mW: Power allocated to a PSE PI to manage power budget in > + * static budget evaluation strategy. > + * @_isr_counter_mismatch: Internal flag used in PSE core in case of a > + * counter mismatch between regulator and PSE API. > + * This is caused by a disable call in the interrupt > + * context handler. The name itself of this field is somewhat concerning, and I don't see it set to any nonzero value here or in later patches. Possibly it should be removed entirely??? /P