Re: [PATCH 5/7] soundwire: sysfs: Use ATTRIBUTE_GROUP_VISIBLE()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David E. Box wrote:
> Replace the manual definition of the dp0 attribute group with the newly
> introduced ATTRIBUTE_GROUP_VISIBLE() macro, simplifying the code and
> improving maintainability.
> 
> Consolidate the definition of dp0_attrs and move the attribute array above
> the macro so that they are visibly tied together.  While here, also remove
> the unneeded trailing comma after NULL at the end of all attribute arrays.

I am generally not a fan of "while we're at it" clauses, but this looks
ok.

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux